Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't update correctly with changed number of nodes #2

Open
jurb opened this issue Oct 28, 2017 · 2 comments
Open

Doesn't update correctly with changed number of nodes #2

jurb opened this issue Oct 28, 2017 · 2 comments
Labels

Comments

@jurb
Copy link

jurb commented Oct 28, 2017

If I update the chart with new data where there are less or more nodes, the resulting chart updates the wrong nodes with the new data.

I guess this can be solved by adding an id to the links, but I'm not sure how that would work with this library.

@fabric-io-rodrigues
Copy link
Owner

Hi @jurb, thanks for your contribution.

Currently it is only possible to update using the same amount of nodes. If you need to update with a different amount of nodes, you must call sk.createSankey (...) and the previous SVG content will be modified.
As soon as possible I will modify the function to support this.

Any other problems or suggestions can tell me.

@jurb
Copy link
Author

jurb commented Oct 31, 2017

@FabricioRHS Ah that's clear, thank you. Looking forward to it! Thanks for creating a great library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants