Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript type error during compilation #4

Open
HamedFathi opened this issue Aug 23, 2022 · 2 comments
Open

Typescript type error during compilation #4

HamedFathi opened this issue Aug 23, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@HamedFathi
Copy link

Thank you so much for your great job.

I found 3 issues in flimsy.annotated.ts file

Function lacks ending return statement and return type does not include 'undefined'.ts(2366)
3

Argument of type 'this' is not assignable to parameter of type 'Signal'.
Type 'Signal' is not assignable to type 'Signal'.

2

Argument of type 'this' is not assignable to parameter of type 'Computation'.
Type 'Observer' is missing the following properties from type 'Computation': fn, signal, waiting, fresh, and 3 more.ts(2345)

1

Is it possible to check them? becuase I cannot build the source code.

@HamedFathi HamedFathi changed the title Type errors in TypeScript Type errors in TypeScript file (flimsy.annotated.ts) Aug 23, 2022
@HamedFathi
Copy link
Author

@fabiospampinato
May I ask you check these? I am not able to build the source code.

@fabiospampinato fabiospampinato added the bug Something isn't working label Nov 15, 2022
@fabiospampinato fabiospampinato changed the title Type errors in TypeScript file (flimsy.annotated.ts) Address TS errors Nov 15, 2022
@fabiospampinato
Copy link
Owner

As I said on twitter they should probably be addressed, though they are not a problem in practice and addressing them would somewhat go against the goal of the project which is to have simple code.

@fabiospampinato fabiospampinato changed the title Address TS errors Typescript type error during compilation Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants