feat: Generate inferred types #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabien0102
commented
Jun 7, 2022
| @@ -0,0 +1,36 @@ | |||
| // Generated by ts-to-zod | |||
There was a problem hiding this comment.
@SrBrahma Can you have a look to the generated file and tell me if this could fit your usecase
There was a problem hiding this comment.
I am kinda busy those days (moving abroad very soon!), but asap will try it and give you the feedback.
fracalo
added a commit
to fracalo/ts-to-zod
that referenced
this pull request
Apr 7, 2023
* upstream/main: fix: support numeric literal keys (fabien0102#120) chore: release 3.0.0 (fabien0102#119) feat: Generate inferred types (fabien0102#85) feat!: Support circular dependencies with loops of length > 1 (fabien0102#114) build: add missing dependency on @oclif/errors (fabien0102#115)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If you want to tweak the generated zod schemas, you can't used the original types (they will be out of sync).
For supporting this usecase, this PR is adding a
inferredTypesoptions to provide a file path.Note
We are generating inferred types in a separate file to avoid any name conflicts, indeed, when you have a circular types, we are using the original type as hint for zod.
Related issue
#81