Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add skipParseJSDoc option #62

Merged
merged 6 commits into from Dec 3, 2021
Merged

Conversation

fabien0102
Copy link
Owner

Why

If we don’t want to have any extra zod validator from the JSDoc, we can now add --skipParseJSDoc option.

Closed #60

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #62 (887bea0) into main (e5e4961) will decrease coverage by 1.24%.
The diff coverage is 95.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   98.49%   97.24%   -1.25%     
==========================================
  Files           8       11       +3     
  Lines         332      472     +140     
  Branches      102      156      +54     
==========================================
+ Hits          327      459     +132     
- Misses          5       10       +5     
- Partials        0        3       +3     
Impacted Files Coverage Δ
src/core/generateZodSchema.ts 95.50% <91.66%> (-1.71%) ⬇️
src/utils/resolveDefaultProperties.ts 95.23% <95.23%> (ø)
src/utils/resolveModules.ts 97.87% <97.87%> (ø)
src/core/generate.ts 100.00% <100.00%> (ø)
src/core/jsDocTags.ts 98.50% <100.00%> (-1.50%) ⬇️
src/core/validateGeneratedTypes.ts 97.50% <100.00%> (+0.13%) ⬆️
src/utils/isNotNull.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d9d8c4...887bea0. Read the comment docs.

@fabien0102 fabien0102 self-assigned this Dec 3, 2021
@fabien0102 fabien0102 merged commit e48c5fe into main Dec 3, 2021
@fabien0102 fabien0102 deleted the skip-js-doc-parse-option branch December 3, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to disable JSDoc parsing
2 participants