Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse top-level JSDoc tag on type #59

Merged
merged 3 commits into from Nov 28, 2021
Merged

Parse top-level JSDoc tag on type #59

merged 3 commits into from Nov 28, 2021

Conversation

fabien0102
Copy link
Owner

Why

The following snippet was not producing any zod validator. This PR ensure that every jsdoc are actually translated to validators.

/**
  * @minLength 1
  */
export type NonEmptyString = string;

I also bump all the possible dependencies to be a up-to-date

Closed #54

@fabien0102 fabien0102 self-assigned this Nov 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #59 (9c95c23) into main (e5e4961) will decrease coverage by 1.26%.
The diff coverage is 95.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   98.49%   97.22%   -1.27%     
==========================================
  Files           8       11       +3     
  Lines         332      469     +137     
  Branches      102      144      +42     
==========================================
+ Hits          327      456     +129     
- Misses          5       10       +5     
- Partials        0        3       +3     
Impacted Files Coverage Δ
src/core/generateZodSchema.ts 95.47% <91.22%> (-1.73%) ⬇️
src/utils/resolveDefaultProperties.ts 95.23% <95.23%> (ø)
src/utils/resolveModules.ts 97.87% <97.87%> (ø)
src/core/generate.ts 100.00% <100.00%> (ø)
src/core/jsDocTags.ts 98.50% <100.00%> (-1.50%) ⬇️
src/core/validateGeneratedTypes.ts 97.43% <100.00%> (+0.06%) ⬆️
src/utils/isNotNull.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e00f1e...9c95c23. Read the comment docs.

@fabien0102 fabien0102 merged commit 33b17f6 into main Nov 28, 2021
@fabien0102 fabien0102 deleted the fix-toplevel-jsdoc branch November 28, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSDoc are applied to wrong schema
2 participants