Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nullable #57

Merged
merged 2 commits into from Nov 22, 2021
Merged

Improve nullable #57

merged 2 commits into from Nov 22, 2021

Conversation

fabien0102
Copy link
Owner

Why

Use nullable() when this is possible, this is solving half of the case from #54 and this is a bit more semantic.

@codecov-commenter
Copy link

Codecov Report

Merging #57 (9f549f6) into main (e5e4961) will decrease coverage by 1.30%.
The diff coverage is 95.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   98.49%   97.19%   -1.31%     
==========================================
  Files           8       11       +3     
  Lines         332      463     +131     
  Branches      102      144      +42     
==========================================
+ Hits          327      450     +123     
- Misses          5       10       +5     
- Partials        0        3       +3     
Impacted Files Coverage Δ
src/core/generateZodSchema.ts 95.45% <91.07%> (-1.75%) ⬇️
src/utils/resolveDefaultProperties.ts 95.23% <95.23%> (ø)
src/utils/resolveModules.ts 97.61% <97.61%> (ø)
src/core/generate.ts 100.00% <100.00%> (ø)
src/core/jsDocTags.ts 98.50% <100.00%> (-1.50%) ⬇️
src/core/validateGeneratedTypes.ts 97.43% <100.00%> (+0.06%) ⬆️
src/utils/isNotNull.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506e54c...9f549f6. Read the comment docs.

@fabien0102 fabien0102 merged commit 0e00f1e into main Nov 22, 2021
@fabien0102 fabien0102 deleted the improve-nullable branch November 22, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants