Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional function parameter #48

Merged
merged 1 commit into from Oct 6, 2021
Merged

Fix optional function parameter #48

merged 1 commit into from Oct 6, 2021

Conversation

fabien0102
Copy link
Owner

Why

Closed #47

@fabien0102 fabien0102 self-assigned this Oct 6, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #48 (02cf133) into main (e5e4961) will decrease coverage by 0.42%.
The diff coverage is 97.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   98.49%   98.06%   -0.43%     
==========================================
  Files           8       10       +2     
  Lines         332      414      +82     
  Branches      102      122      +20     
==========================================
+ Hits          327      406      +79     
- Misses          5        6       +1     
- Partials        0        2       +2     
Impacted Files Coverage Δ
src/utils/resolveDefaultProperties.ts 95.23% <95.23%> (ø)
src/utils/resolveModules.ts 97.61% <97.61%> (ø)
src/core/generate.ts 100.00% <100.00%> (ø)
src/core/generateZodSchema.ts 97.41% <100.00%> (+0.21%) ⬆️
src/core/jsDocTags.ts 98.46% <100.00%> (-1.54%) ⬇️
src/core/validateGeneratedTypes.ts 97.43% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e13bbb...02cf133. Read the comment docs.

@fabien0102 fabien0102 merged commit 59d28e0 into main Oct 6, 2021
@fabien0102 fabien0102 deleted the optional-param branch October 6, 2021 17:16
fabien0102 added a commit that referenced this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional function parameters are not marked as optional
2 participants