Support namespace #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Known issue, this doesn’t work with all type references
Codecov Report
@@ Coverage Diff @@
## main #44 +/- ##
==========================================
- Coverage 98.49% 98.06% -0.43%
==========================================
Files 8 10 +2
Lines 332 414 +82
Branches 102 122 +20
==========================================
+ Hits 327 406 +79
- Misses 5 6 +1
- Partials 0 2 +2
Continue to review full report at Codecov.
|
|
I need to add a namespace in the example, something is not following 😉 |
Closed
fabien0102
added a commit
that referenced
this pull request
Sep 20, 2021
* Resolve module as first step Known issue, this doesn’t work with all type references * Deal with module * Add a namespace in the example and fix generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Module was not supported, to handle those, I did add a little pre-processor to flatten them applying a prefix (more details in the unit tests)
Issue
#43