Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typescript version #28

Merged
merged 2 commits into from May 28, 2021
Merged

fix: Fix typescript version #28

merged 2 commits into from May 28, 2021

Conversation

fabien0102
Copy link
Owner

Why

Apparently newest version of typescript are breaking some type comparisons, also this is more safe to have a stable version of typescript for this project (since we are using the compiler API).

Related issue

#27

@fabien0102 fabien0102 self-assigned this May 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #28 (bf32c58) into main (e5e4961) will decrease coverage by 0.46%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   98.49%   98.02%   -0.47%     
==========================================
  Files           8        9       +1     
  Lines         332      355      +23     
  Branches      102      100       -2     
==========================================
+ Hits          327      348      +21     
- Misses          5        6       +1     
- Partials        0        1       +1     
Impacted Files Coverage Δ
src/utils/resolveDefaultProperties.ts 95.23% <95.23%> (ø)
src/core/generateZodSchema.ts 97.22% <100.00%> (+0.01%) ⬆️
src/core/jsDocTags.ts 98.46% <100.00%> (-1.54%) ⬇️
src/core/validateGeneratedTypes.ts 97.43% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74f1889...bf32c58. Read the comment docs.

@fabien0102 fabien0102 merged commit 5bdecbc into main May 28, 2021
@fabien0102 fabien0102 deleted the fix-typescript-version branch May 28, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants