Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation on same-file generation #221

Merged
merged 1 commit into from Apr 10, 2024
Merged

fix: validation on same-file generation #221

merged 1 commit into from Apr 10, 2024

Conversation

tvillaren
Copy link
Collaborator

Fixes #219

Haven't added tests as they would need to be at the CLI level.

I've already spent quite some time trying to configure @oclif/test but I think we're missing some configuration on Oclif for the library (@oclif/test doesn't find the command)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (e21ea92) to head (20175f4).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          18       18           
  Lines         922      922           
  Branches      368      368           
=======================================
  Hits          885      885           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvillaren tvillaren changed the title Fix validation on same-file generation fix: validation on same-file generation Apr 8, 2024
@tvillaren tvillaren marked this pull request as ready for review April 8, 2024 07:20
@tvillaren tvillaren self-assigned this Apr 8, 2024
@tvillaren tvillaren merged commit c146e83 into main Apr 10, 2024
4 checks passed
@tvillaren tvillaren deleted the fix-219 branch April 10, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate schema from types within one file
2 participants