Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: use default passed to generate #215

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

deckchairlabs
Copy link

Why

This PR resolves #213, a very simple change.

@tvillaren
Copy link
Collaborator

Hey @deckchairlabs,

Thank you for your PR, it seems that the tests don't pass anymore.
Would you mind having a look?

Also, you committed a few changes that seem to be only spacing changes 👉 there is a yarn lint task that you may want to use to clean those out.

@deckchairlabs
Copy link
Author

Apologies! I rushed this at the end of the day! Wondering how you feel about this change, since it does change behavior, I imagine people updating might have to rename a bunch of imports now.

@schiller-manuel
Copy link
Collaborator

if this is a breaking change we can only merge it in v4

@tvillaren
Copy link
Collaborator

Thanks for the update 🙏

Indeed, that would change the current behaviour implemented last month.
To sum up:

Current

  • Generated file: Generate getSchemaName | DEFAULT
  • Imported files: IO Mapping getSchemaName | DEFAULT

Proposed

  • Generated file: Generate getSchemaName | DEFAULT
  • Imported files: IO Mapping getSchemaName | Generate getSchemaName | DEFAULT

So this would mean that users relying on the generate method with a specific getSchemaName that they don't want to apply for imports would need to update their config file to set an alternative their (i.e. what users currently have to do in reverse).
This concerns users who updated to 3.7.3 and starting using the import handling feature.

I don't have a strong opinion for proposed or current behaviour: I implemented the import handling feature without giving this particular point a thought, as I myself rely on the default in my work 😅

@tvillaren tvillaren changed the title fix: use default passed to generate fix!: use default passed to generate Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getSchemaName not applied to imports
3 participants