Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: context binding while processing errors #209

Merged
merged 1 commit into from Feb 23, 2024

Conversation

elquid
Copy link
Contributor

@elquid elquid commented Feb 21, 2024

Why

This PR fixes #185.

How to reproduce

Input file:

export interface IHaveUnknownDependency {
  dep: UnknownDependency;
}

Actual output:

TypeError: Cannot read properties of undefined (reading 'jsonEnabled')
error Command failed with exit code 1.

Expected output:

 »   Warning: Some schemas can't be generated due to direct or indirect missing 
 »   dependencies:
 »   iHaveUnknownDependencySchema
✔ Validating generated types
🎉 Zod schemas generated!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.20%. Comparing base (8979a6f) to head (71161ba).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files          15       15           
  Lines         823      823           
  Branches      334      334           
=======================================
  Hits          800      800           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schiller-manuel schiller-manuel merged commit 2db450b into fabien0102:main Feb 23, 2024
4 checks passed
@elquid elquid deleted the fix-issue-185 branch April 27, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'jsonEnabled')
3 participants