Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add JSDoc tags for string and number array elements #180

Merged
merged 1 commit into from Nov 28, 2023

Conversation

schiller-manuel
Copy link
Collaborator

@schiller-manuel schiller-manuel commented Nov 16, 2023

I wanted to be able to add validators for plain string[] and number[].
With this PR I propose the following additional JSDoc tags:

 @elementMinimum
 @elementMaximum
 @elementMinLength
 @elementMaxLength
 @elementPattern
 @elementFormat

For details please see the tests and README.md

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb9618f) 97.35% compared to head (88c43b0) 97.37%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   97.35%   97.37%   +0.02%     
==========================================
  Files          14       14              
  Lines         718      724       +6     
  Branches      293      299       +6     
==========================================
+ Hits          699      705       +6     
  Misses         19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schiller-manuel schiller-manuel merged commit df5be8b into fabien0102:main Nov 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants