Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Handling negative literals #132

Merged
merged 4 commits into from May 17, 2023
Merged

[Fix] Handling negative literals #132

merged 4 commits into from May 17, 2023

Conversation

tvillaren
Copy link
Collaborator

Why

This fixes #101

fabien0102
fabien0102 approved these changes May 17, 2023
View reviewed changes
Copy link
Owner

@fabien0102 fabien0102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and amazing PR! I just replace the type assertion by ts.isPrefixUnaryExpression (it's a bit cleaner and safer to use 😉)

@fabien0102 fabien0102 merged commit a1ad399 into fabien0102:main May 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabien0102 fabien0102 fabien0102 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The "-1" and "0" literals do not work
2 participants
@tvillaren @fabien0102