Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "no" trigger when switching tabs using cmnd + 1 #187

Open
Halvor-08 opened this issue Jan 27, 2021 · 5 comments
Open

Remove "no" trigger when switching tabs using cmnd + 1 #187

Halvor-08 opened this issue Jan 27, 2021 · 5 comments

Comments

@Halvor-08
Copy link

Halvor-08 commented Jan 27, 2021

On Mac, when reviewing kanji, the keybind to answer cards as "no" with the 1 key also triggers when attempting to switch between tabs (using cmnd + 1). Maybe there could be an option to turn this off or add a toggle?

@talmobi
Copy link

talmobi commented Jan 27, 2021

As a side note, you can also switch tabs using CTRL+TAB and CTRL+SHIFT+TAB.

On a mac it's a bit awkward to press these unless you make your CAPS_LOCK key into an extra CTRL TAB. Which you can do on a mac just by going to keyboard settings (builtin future).

@Halvor-08 Halvor-08 changed the title Remove Cmnd + number keybind when reviewing Remove "no" trigger when switching tabs using cmnd + 1 Jan 27, 2021
@fabd
Copy link
Owner

fabd commented Jan 28, 2021

Interesting issue.

Tried in Linux Cmd (Win) + 1 for me it activates another app (same behaviour as Windows taskbar, in Ubuntu the "Dash to Panel"extension is awesome and has similar shortcut). No issue there.

In Chrome/Chromium I tried Ctrl + number : this switches directly to a given tab, presumably this uses Cmd + number on MacOS ? Or did you remap those keybinds? Because in Ubuntu + Chrome CTRL + 1 switches tab, and does not activate the flashcard shortcut. So a priori no issue there.

Not sure if this is addressable, or if it's meant to be addressed by the site.

Only thing that comes to mind is that I could check for modifier keys. Assuming it's possible to detect the Cmd key in MacOS browser via Javascript, then the shortcut code could check that no modifier key is active. Problem is I have no way of verifying that it works and I don't like pushing code that I can't assert myself does what is intended.

@fabd
Copy link
Owner

fabd commented Jan 28, 2021

Could also in the future add a checkbox to activate / deactivate given shortcuts, or deactivate all the numbered shortcuts ( there is already Y, N , etc). I do think in retrospect short of ability to remap thenm, the user should be able to just turn them off in order to free them for other uses. However I don't want to add more settings, database updates and so on at this stage with the big migration to Laravel I announced recently, so any workable fix in the short term has to be something simple.

@Halvor-08
Copy link
Author

Completely understandable, it was just something I noticed.
P.S. Wish you the best of luck with the migration!

@Halvor-08
Copy link
Author

As a side note: when reviewing cards none of the shortcuts with cmnd + 1, 2, 3 or 4 work anymore (even though the last three don't have a function when the card isn't turned yet) Basically a really weird bug that intervenes with browser- but not system shortcuts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants