Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tslib import issues in #12 are still rampant #270

Closed
IronSean opened this issue May 18, 2021 · 3 comments
Closed

tslib import issues in #12 are still rampant #270

IronSean opened this issue May 18, 2021 · 3 comments
Labels
kind: support Asking for support with something or a specific use case problem: no repro No reproduction was provided (and have not tried to repro without one) problem: stale Issue has not been responded to in some time scope: dependencies Issues or PRs about updating a dependency solution: duplicate This issue or pull request already exists solution: tsc behavior This is tsc's behavior as well, so this is not a bug with this plugin

Comments

@IronSean
Copy link

#12 is already closed but the regular and ongoing conversation shows the issues aren't resolved and adding direct dependencies for things that should be resolved automatically is still the best bandage solution propsed.

@ezolenko
Copy link
Owner

tslib 2.1.0 is already a direct dependency of rpt2, so it should work, unless you are using something not in 2.1.0?

@IronSean
Copy link
Author

I think we tracked it down to being issues with npm 7, reverting to npm 6 and it's older dependency resolution approach seemed to fix things.

@agilgur5 agilgur5 added kind: support Asking for support with something or a specific use case problem: stale Issue has not been responded to in some time problem: no repro No reproduction was provided (and have not tried to repro without one) solution: duplicate This issue or pull request already exists solution: out-of-scope This is out of scope for this project scope: dependencies Issues or PRs about updating a dependency labels May 2, 2022
@agilgur5
Copy link
Collaborator

agilgur5 commented May 2, 2022

Closing this out as OP was able to resolve this themselves and it did not seem to be an issue with this plugin.
Much of the remaining discussions in #12 are very similar, where some dependency resolution isn't working and a fresh install or something else makes it work, so also marking as duplicate in that sense.

#12 is already closed but the regular and ongoing conversation

The original issue is also like ~5 years old and was resolved with moduleResolution: 'node' (vs. the legacy classic option), so I'm actually not sure that the further discussion there is related to the original issue either.

Also, #293 unlocked the version of tslib in this plugin's dependencies, so that should help with any dependency resolution issues as well.

Hasn't been any discussion here or there in about a year now too.

@agilgur5 agilgur5 closed this as completed May 2, 2022
Repository owner locked as resolved and limited conversation to collaborators Jun 9, 2022
@agilgur5 agilgur5 added solution: tsc behavior This is tsc's behavior as well, so this is not a bug with this plugin and removed solution: out-of-scope This is out of scope for this project labels Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind: support Asking for support with something or a specific use case problem: no repro No reproduction was provided (and have not tried to repro without one) problem: stale Issue has not been responded to in some time scope: dependencies Issues or PRs about updating a dependency solution: duplicate This issue or pull request already exists solution: tsc behavior This is tsc's behavior as well, so this is not a bug with this plugin
Projects
None yet
Development

No branches or pull requests

3 participants