Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reminder]: Some hooks deprecated since Rollup v1.0.0 #126

Closed
DrSensor opened this issue Dec 29, 2018 · 5 comments
Closed

[Reminder]: Some hooks deprecated since Rollup v1.0.0 #126

DrSensor opened this issue Dec 29, 2018 · 5 comments
Assignees
@ezolenko
Labels
kind: optimization Performance, space, size, etc improvement

Comments

@DrSensor
Copy link

What happens and why it is wrong

https://github.com/rollup/rollup/releases/tag/v1.0.0

(!) rpt2 plugin: The ongenerate hook used by plugin rpt2 is deprecated. The generateBundle hook should be used instead.
(!) rpt2 plugin: The onwrite hook used by plugin rpt2 is deprecated. The generateBundle hook should be used instead.

Versions

  • typescript: 3.2.2
  • rollup: 1.0.0
  • rollup-plugin-typescript2: 0.18.1
@ufocoder
Copy link

ufocoder commented Jan 1, 2019

Hooks used by rollup-plugin-typescript2 have been deprecated

@Turbo87 Turbo87 mentioned this issue Jan 2, 2019
Merged
@ezolenko ezolenko self-assigned this Jan 3, 2019
ezolenko added a commit that referenced this issue Jan 4, 2019
@ezolenko
- redoing switch to generateBundle (#126 #127 #128)
6b0225a 
- using rollup's own types
- min rollup bumped to 0.68
- updating dependencies
- package version 0.19
@onigoetz onigoetz mentioned this issue Jan 9, 2019
Merged
1 task
@JoshLipan

This comment was marked as spam.

Sign in to view
@aladdin-add
Copy link

seem it has been fixed on master, mind releasing a patch? @ezolenko

@ezolenko
Copy link
Owner

Yep, this is fixed in 19.0+, I'll do a release soonish

@ezolenko
Copy link
Owner

ezolenko commented Jan 16, 2019 •
edited by agilgur5

In 0.19.0 now

@BuptStEve BuptStEve mentioned this issue Jan 31, 2019
Merged
kazupon added a commit to kazupon/vue-cli-plugin-p11n that referenced this issue Feb 1, 2019
@kazupon
⚡ improvement(build): suppress rollup deprecated warning
3604589 
NOTE:
ezolenko/rollup-plugin-typescript2#126
@agilgur5 agilgur5 added the kind: optimization Performance, space, size, etc improvement label May 21, 2022
Repository owner locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ezolenko ezolenko

Labels
kind: optimization Performance, space, size, etc improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ezolenko @ufocoder @DrSensor @agilgur5 @aladdin-add @JoshLipan