-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Noticeable delay on playing sfx #510
Comments
Don't recall anything beyond what I noted in the commit comments. I think we tested other platforms at the time and didn't notice an adverse impact, but if we are seeing one now, an ifdef is fine (maybe with a comment linking to this issue). |
Dominus, I have taken the liberty to rework your commit a bit, to ensure that the branches of the Also I think your commit helped my SDL 3 port. I have the feeling that the lip syncing of the Guardian during its speech in the Intro of The Black Gate is better with your commit. In SDL 2 and in SDL 3. |
I have no problem with any change ;) And yes, I didn't think of the lip synch but it makes sense that this was also affected. |
I think we only tested digital music and never thought of testing other outputs :) |
I'm setting this to be an Android bug as it's fixed for other systems and might need a different fix than changing the Hz to avoid having the digital music stutter on Android. |
@ceckak introduced a noticeable delay in playing sfx with fa172c4
Test case: open the inventory with 'i' with version 1.8 vs current code. Git bisect lead me to this commit.
@ceckak do you remember much about this case. I know we talked about it and I tested things. Maybe this needs to be an ifdef Android?
The text was updated successfully, but these errors were encountered: