Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Noticeable delay on playing sfx #510

Open
DominusExult opened this issue Apr 28, 2024 · 5 comments
Open

Android: Noticeable delay on playing sfx #510

DominusExult opened this issue Apr 28, 2024 · 5 comments

Comments

@DominusExult
Copy link
Member

@ceckak introduced a noticeable delay in playing sfx with fa172c4

Test case: open the inventory with 'i' with version 1.8 vs current code. Git bisect lead me to this commit.

@ceckak do you remember much about this case. I know we talked about it and I tested things. Maybe this needs to be an ifdef Android?

@ceckak
Copy link
Contributor

ceckak commented Apr 29, 2024

Don't recall anything beyond what I noted in the commit comments. I think we tested other platforms at the time and didn't notice an adverse impact, but if we are seeing one now, an ifdef is fine (maybe with a comment linking to this issue).

@Dragon-Baroque
Copy link
Contributor

Dominus, I have taken the liberty to rework your commit a bit, to ensure that the branches of the #ifdef ANDROID do not contain unpaired braces. This helps my syntax coloring editor not to get lost in finding pairing braces...

Also I think your commit helped my SDL 3 port. I have the feeling that the lip syncing of the Guardian during its speech in the Intro of The Black Gate is better with your commit. In SDL 2 and in SDL 3.

@DominusExult
Copy link
Member Author

I have no problem with any change ;)

And yes, I didn't think of the lip synch but it makes sense that this was also affected.
The iOS port also had stuttering that I couldn't pin point which is now also gone.

@DominusExult
Copy link
Member Author

DominusExult commented Apr 29, 2024

Don't recall anything beyond what I noted in the commit comments. I think we tested other platforms at the time and didn't notice an adverse impact, but if we are seeing one now, an ifdef is fine (maybe with a comment linking to this issue).

I think we only tested digital music and never thought of testing other outputs :)
I'm seeing the sfx delay on Android in the emulator as well :(

@DominusExult DominusExult changed the title Noticeable delay on playing sfx Android: Noticeable delay on playing sfx Apr 30, 2024
@DominusExult
Copy link
Member Author

I'm setting this to be an Android bug as it's fixed for other systems and might need a different fix than changing the Hz to avoid having the digital music stutter on Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants