You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found two cases that the original way of assigning sfx to shapes makes not that much sense and likely not what they intended.
# Well of Souls
#
:748/52
It makes no sense for frame 0 to play the watery sfx, but the filled up well should play it.
# Smokebomb
#
:769/52
The bottled up smokebomb (frame 0) shouldn't play an sfx, but the open bottle (frame 1) should briefly play the sfx (and in this case play it once completely as it quickly disappears when the smoke is freed).
Maybe it would make sense to adapt the shapenumber section to allow setting a frame as well. Preferably without breaking compatibility of patched shape_info.txt files
The text was updated successfully, but these errors were encountered:
I found two cases that the original way of assigning sfx to shapes makes not that much sense and likely not what they intended.
It makes no sense for frame 0 to play the watery sfx, but the filled up well should play it.
The bottled up smokebomb (frame 0) shouldn't play an sfx, but the open bottle (frame 1) should briefly play the sfx (and in this case play it once completely as it quickly disappears when the smoke is freed).
Maybe it would make sense to adapt the shapenumber section to allow setting a frame as well. Preferably without breaking compatibility of patched shape_info.txt files
The text was updated successfully, but these errors were encountered: