Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape SFX in shape_info.txt allow setting per frame #505

Open
DominusExult opened this issue Apr 21, 2024 · 1 comment
Open

Shape SFX in shape_info.txt allow setting per frame #505

DominusExult opened this issue Apr 21, 2024 · 1 comment

Comments

@DominusExult
Copy link
Member

I found two cases that the original way of assigning sfx to shapes makes not that much sense and likely not what they intended.

#	Well of Souls
#
:748/52

It makes no sense for frame 0 to play the watery sfx, but the filled up well should play it.

#	Smokebomb
#
:769/52

The bottled up smokebomb (frame 0) shouldn't play an sfx, but the open bottle (frame 1) should briefly play the sfx (and in this case play it once completely as it quickly disappears when the smoke is freed).

Maybe it would make sense to adapt the shapenumber section to allow setting a frame as well. Preferably without breaking compatibility of patched shape_info.txt files

@NotStanley4330
Copy link
Contributor

This should be doable. I can look at this today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants