Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI Fixes request: Batlin wearing the Fellowship Medallion when viewed through the eye of the moon #435

Open
DominusExult opened this issue Jan 21, 2024 · 4 comments

Comments

@DominusExult
Copy link
Member

When Batlin is viewed through the Eye of the Moon and speaks to his henchmen the Batlin face with the Fellowship Medallion is used.
Chronologically this happens AFTER he has lost/left his medallion in Shamino's castle, so he shouldn't be wearing it.

This is a bug in the original usecode (?). Teleport to dec 1463,997 to view the Eye of the Moon.

image

@KnightCaptainU7
Copy link
Contributor

Yes, it's a Origin Usecode bug. Sadly the cutscene is buried in the code tied to the shape of Batlin, and it's not the only occurrence within the file of the wrong frame being used.

I last edited the file in 2017, and never finished the conversion.
batlin.uc.txt

`void shapeBatlin shape#(0x13E) () // 318

if (gflags[BEGIN_VISION_OF_BATLIN] && ((event == PROXIMITY) && (!gflags[FINISHED_VISION_OF_BATLIN])))
{
if (UI_get_npc_id(item) == 5)
{
UI_init_conversation();
// Should use frame 1 here, without the medallion.
UI_show_npc_face0(FACE_BATLIN, 1);
say("@to thee I give the anchor's job... The Avatar must not enter the Shrine of Balance before the Wall of Lights is fully open. Thou must stop the Avatar, should the others fail.@");`

@KnightCaptainU7
Copy link
Contributor

I wonder if simply changing the order of the two face frames would be a better fix? Then it would be correct. And we may assume Batlin removed it before his battle with Cantra rather than after?

@KnightCaptainU7
Copy link
Contributor

@KnightCaptainU7
Copy link
Contributor

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants