Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotate image #1254

Open
Mattwmaster58 opened this issue Oct 29, 2023 · 2 comments
Open

rotate image #1254

Mattwmaster58 opened this issue Oct 29, 2023 · 2 comments

Comments

@Mattwmaster58
Copy link
Contributor

Is your feature request related to a problem? Please describe., Describe the solution you'd like,
Sometimes I'd like to rotate an image.

Describe alternatives you've considered
Turning my head to the side

Additional context
I am planning to implement this and want feedback on if a PR would be accepted, any suggestions with the implementation, etc

@GrosPoulet
Copy link
Collaborator

@Mattwmaster58 i suggest you have a look at #774 : implementation of image & video flip.

@Mattwmaster58
Copy link
Contributor Author

Hmm, looking for anyones opinion here as I'm not experienced with the codebase, what do you think the best way to implement the chaining of transforms? Previously it was sufficient to compare to the current transform: matrix(..) value, but adding in rotations 4*4 = 16 possibilities.

AFAICT, we can either nest elements to chain effects (dummy div?), or we could parse out the values of the matrix change the value that way maybe? That will require me to brush up on my linear algebra ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants