-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Passport Middleware #108
Comments
Could you please allocate this to me? I'm interested in taking it on. Are there any specific timelines for its completion or release? |
Hi Hoda, yes, it's assigned to you. Regarding the timelines, as fast as you can complete would be great. As we do have many people working on the project we want to avoid stale issues. Looking forward to hearing updates on this task. |
hey @rsaz ,is the issue completed or i can also be assigned to this task? |
Hi @pnkjbee2 this issue is already assigned to @HodaSalim . I can assign this middleware to you instead #113 , let me know. |
guess , that one is also gone. |
@rsaz can I give it a try ? |
Hi @AkhileshJyotishi and @pnkjbee2 this task is assigned to you all. Whoever finishes first and the code is correctly implemented, it will be merged and get the issue to completion, remaining the assignee that completed the task only. |
Assigned to you, good luck! |
@rsaz thanks |
@rsaz can you review the changes! |
@rsaz Can you review the changes please ! |
Hi @AkhileshJyotishi I will be able to review this PR by Friday or Saturday. You will receive an update soon about it. Thank you |
Is there an existing issue for this?
Current behavior
We have a middleware service where we do add services that can be used dynamically by the developer during the application development like so:
The middleware are added in the middleware service as mentioned above as well as it's interfaces implemented here.
The interfaces are the options that can be optionally passed to the middleware.
This task has the objective of implementing the middleware Passport embedded in the ExpressoTS platform as the other middlewares.
More information here: https://github.com/jaredhanson/passport
Steps to reproduce
N/A
Expected behavior
Implemented passport middleware and make it available as an option in the application provider class
Package version
2.2.1
Node.js version
In which operating systems have you tested?
Other
No response
The text was updated successfully, but these errors were encountered: