Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Passport Middleware #108

Open
4 tasks done
rsaz opened this issue Sep 25, 2023 · 12 comments
Open
4 tasks done

Implement Passport Middleware #108

rsaz opened this issue Sep 25, 2023 · 12 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest issues needs triage Needs analysis

Comments

@rsaz
Copy link
Member

rsaz commented Sep 25, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

We have a middleware service where we do add services that can be used dynamically by the developer during the application development like so:

@provide(App)
export class App extends AppExpress {
    private middleware: IMiddleware;
    private provider: IProvider;

    constructor() {
        super();
        this.middleware = container.get<IMiddleware>(Middleware);
        this.provider = container.get<IProvider>(Provider);
    }

    protected configureServices(): void {
        this.middleware.addBodyParser();
        this.middleware.setErrorHandler();
    }

    protected postServerInitialization(): void {
        if (this.isDevelopment()) {
            this.provider.envValidator.checkAll();
        }
    }

    protected serverShutdown(): void {}
}

The middleware are added in the middleware service as mentioned above as well as it's interfaces implemented here.
The interfaces are the options that can be optionally passed to the middleware.

This task has the objective of implementing the middleware Passport embedded in the ExpressoTS platform as the other middlewares.

More information here: https://github.com/jaredhanson/passport

Steps to reproduce

N/A

Expected behavior

Implemented passport middleware and make it available as an option in the application provider class

Package version

2.2.1

Node.js version

18

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@rsaz rsaz added needs triage Needs analysis enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest issues labels Sep 25, 2023
@HodaSalim
Copy link

Could you please allocate this to me? I'm interested in taking it on. Are there any specific timelines for its completion or release?

@rsaz rsaz assigned rsaz and HodaSalim and unassigned rsaz Sep 29, 2023
@rsaz
Copy link
Member Author

rsaz commented Sep 29, 2023

Could you please allocate this to me? I'm interested in taking it on. Are there any specific timelines for its completion or release?

Hi Hoda, yes, it's assigned to you. Regarding the timelines, as fast as you can complete would be great. As we do have many people working on the project we want to avoid stale issues. Looking forward to hearing updates on this task.

@pnkjbee2
Copy link

hey @rsaz ,is the issue completed or i can also be assigned to this task?

@rsaz
Copy link
Member Author

rsaz commented Sep 30, 2023

hey @rsaz ,is the issue completed or i can also be assigned to this task?

Hi @pnkjbee2 this issue is already assigned to @HodaSalim .

I can assign this middleware to you instead #113 , let me know.

@pnkjbee2
Copy link

guess , that one is also gone.

@AkhileshJyotishi
Copy link
Contributor

@rsaz can I give it a try ?

@rsaz
Copy link
Member Author

rsaz commented Oct 4, 2023

Hi @AkhileshJyotishi and @pnkjbee2 this task is assigned to you all. Whoever finishes first and the code is correctly implemented, it will be merged and get the issue to completion, remaining the assignee that completed the task only.

@rsaz
Copy link
Member Author

rsaz commented Oct 4, 2023

guess , that one is also gone.

Assigned to you, good luck!

@pnkjbee2
Copy link

pnkjbee2 commented Oct 4, 2023

@rsaz thanks

@AkhileshJyotishi
Copy link
Contributor

@rsaz can you review the changes!

@AkhileshJyotishi
Copy link
Contributor

@rsaz Can you review the changes please !

@rsaz
Copy link
Member Author

rsaz commented Oct 19, 2023

@rsaz Can you review the changes please !

Hi @AkhileshJyotishi I will be able to review this PR by Friday or Saturday. You will receive an update soon about it. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest issues needs triage Needs analysis
Projects
Status: Backlog
Development

No branches or pull requests

4 participants