Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State minimum required version of Node.js #1478

Closed
crandmck opened this issue Apr 1, 2024 · 5 comments
Closed

State minimum required version of Node.js #1478

crandmck opened this issue Apr 1, 2024 · 5 comments
Labels

Comments

@crandmck
Copy link
Member

crandmck commented Apr 1, 2024

For 4.x, this file indicates versions that are tested against. So we require Node.js 0.10 or later. While this is a very old version, we should still state it somewhere in the doc.

For 5.x, we need to indicate the required min version, which will be a more recent version, still TBD by the TC.

@crandmck
Copy link
Member Author

crandmck commented Apr 3, 2024

lol, I opened a similar issue about 8 years ago.

@UlisesGascon
Copy link
Member

For 4.x, this file indicates versions that are tested against. So we require Node.js 0.10 or later. While this is a very old version, we should still state it somewhere in the doc.

Agree, let's see if the community want to create a PR for this.

For 5.x, we need to indicate the required min version, which will be a more recent version, still TBD by the TC.

Just to summarize some conversations made recently, seems like we will be following the Node.js release schedule for new releases. Then in the case of v5.x I assume that we can target Node.js 18 as the minimum version.

Node: Node.js 18 end of life is targeted for 2025-04-30, details

@inigomarquinez
Copy link
Member

Hi here!

I can take care of creating a couple of PRs to update this in the documentation if you agree!

@crandmck
Copy link
Member Author

crandmck commented Apr 9, 2024

@inigomarquinez Sure, thanks! But for 5.x I think the TC still hasn't come to a firm conclusion yet.

... Sorry, I stand corrected! I missed the above comment from @UlisesGascon

@crandmck
Copy link
Member Author

crandmck commented May 2, 2024

Fixed with #1495

@crandmck crandmck closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants