This repository has been archived by the owner on Sep 14, 2022. It is now read-only.
Support for CSRF token patterns as instructed by OWASP. #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttern' - changes to HISTORY.md
|
Hello Team, Please allow me to run workflows. cc: @dougwilson Thanks, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows selection of
csrfTokenPatternto be used. Support for HMAC based token pattern and encryption based token pattern added. Defaults to double submit cookie pattern.Closes #121
Thanks @dougwilson for helping out in opening up PR creation for non-existing collaborators like me, who would love to contribute in this repository.
Team, please let me know your reviews. I have added new test cases too. Old ones need not be changed as the change is backward compatible.
While going through the OWASP documentation, I realized that we can have the csrfTokenPattern as an input for a pattern factory that helps select and execute the generation of the token and its validation. Also the factory design will help in pluggable implementation of more patterns in future.