@dougwilson Any update on this ?

I'm interested in this feature but as @papandreou 's branch is way behind the official master. Seems like it's going to be hard to pull...

Is there any proper other way to handle ISO-8859-1 encoded data ?

Hi @Xtrem65 I haven't even commented on here, let alone done any work on it :) I don't have any updates.

@Xtrem65, I guess the only update is that you're expressing interest, which is also a good thing :)

If @dougwilson and @ljharb think the work looks good and they want to adopt this feature, I'd be willing to bring the branches up to date.

@Xtrem65, have you tried switching to my body-parser-papandreou fork to see if it solves your problem? It should still work with current versions of express.

I’d be happy to review a PR.

@ljharb, that sounds great. Before I try to rebase it on qs master, does this approach look good? papandreou/qs@9250c4c...interpretNumericEntities

I'd need to review it when rebased :-) it looks like a good direction tho.

Rebased branch: https://github.com/papandreou/body-parser/tree/feature/iso-8859-1/take2

Requires ljharb/qs#268 to be npm linked in.

Wow guys ! so much reactivity :D

I'd be happy to help if needed

@Xtrem65, you can help by trying it out :)

1. Make a clone of https://github.com/papandreou/qs
2. Check out the feature/iso8859-1 branch
3. npm link
4. Make a clone of https://github.com/papandreou/body-parser
5. Check out the feature/iso-8859-1/take2 branch
6. npm link qs
7. npm link
8. cd to your project
9. npm link body-parser

... Then see if you can solve your problem. Depending on the requests that you need to support, you might have to specify the defaultCharset option.

Closing as niche interest. Looks like some code was written to get folks who want this started. If someone wants to revive this and open a PR, we can get the defibrillator out on this issue.

indeed, the qs code for this is in v6.6.0+, so only body-parser would need changes.

@jonchurch, it's implemented by this PR, which has been sitting there for almost 5 years, waiting for a new major release that ditches support for node.js 0.10 and below :)

apologies @papandreou I missed that PR link while triaging on mobile. I thought a PR never came through, will open this back up as there's a PR attached.

Getting up to speed on this request, as I have never had to deal with this problem. But Im all for better supporting common bodies on the internet via config options.

Reopening