Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1258: added some props into IsURLOptions interface #1259

Merged
merged 2 commits into from May 18, 2024
Merged

#1258: added some props into IsURLOptions interface #1259

merged 2 commits into from May 18, 2024

Conversation

Makarovks320
Copy link
Contributor

@Makarovks320 Makarovks320 commented Nov 1, 2023 •
edited by fedeci

I have added some props into IsURLOptions interface that may be needed in the function isFQDN()

Relevant issue:
Closes #1258

Description

To-do list

  • [-] I have added tests for what I changed.
  • This pull request is ready to merge.

express-validator#1258: added some props into IsURLOptions interface
25a2d32 
these props may be needed in the function isFQDN()
gustavohenke
gustavohenke reviewed Nov 4, 2023
View reviewed changes
src/options.ts Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 6, 2023 •
edited

Coverage Status

coverage: 100.0%. remained the same
when pulling 20a70da on Makarovks320:#1258
into 28a8d5f on express-validator:master.

@gustavohenke gustavohenke merged commit 57a0a15 into express-validator:master May 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavohenke gustavohenke gustavohenke approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS Error. Type 'IsURLOptions' does not include some properties
3 participants
@Makarovks320 @coveralls @gustavohenke