Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grey line drawn for non-Likert types #6

Open
earcanal opened this issue Sep 17, 2018 · 11 comments
Open

Grey line drawn for non-Likert types #6

earcanal opened this issue Sep 17, 2018 · 11 comments

Comments

@earcanal
Copy link

In style.css this

/* Add gray line for Likert */

form p:before {
  content: '';
  position:relative;
  top:53px;
  left:61px;
  display:block;
  background-color:#efefef;
  height:4px;
  width:888px;
}

produces grey lines in non-likert form elements (e.g. information). Perhaps Likert types such as radio could add a likert class to their <p> elements and the selector could be form p.likert:before?

@vsoch
Copy link
Member

vsoch commented Sep 17, 2018

yeah! Can you do an example and possibly PR so we can take a look and discuss?

@earcanal
Copy link
Author

Do you want an example of the issue? I don't think I should go near the python that generates index.html!

@vsoch
Copy link
Member

vsoch commented Sep 17, 2018

just to show the difference between the two renderings, and then the code you already provided. I can definitely do the edits to the final code.

FYI I'm going to be afk for a bit so when you post I can look later!

@earcanal
Copy link
Author

Example

FIXME suggestion

@vsoch
Copy link
Member

vsoch commented Sep 17, 2018

Oh I see, so the visual style doesn’t change but the user can select them easily?

@earcanal
Copy link
Author

Have a look at the example again (I've reverted style.css to show the issue more clearly).

@vsoch
Copy link
Member

vsoch commented Sep 17, 2018

Sorry I don’t see how two compare the two links... for a really stupid dinosaur like myself could you post images here with a BEFORE an AFTER? Ty :)

@earcanal
Copy link
Author

Here's a screenshot of the issue, a visual of my current workaround, and the proposal for a fix.
issue

@vsoch
Copy link
Member

vsoch commented Sep 17, 2018

ah okay! So this picture is the BEFORE (or bug) do you have a shot of the after with the fix?

@vsoch
Copy link
Member

vsoch commented Sep 17, 2018

here I can make one too :)

image

@vsoch
Copy link
Member

vsoch commented Sep 17, 2018

yes I definitely +1 here! Would you like to PR to the branch, I'll build a testing container, we can test to ensure it produces the fixed survey, then deploy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants