Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with rewriting simplification passes using a library like sympy #596

Open
SamirDroubi opened this issue Mar 17, 2024 · 0 comments
Assignees
Labels
C: Internal Implementation detail S: Available Available to be worked upon

Comments

@SamirDroubi
Copy link
Collaborator

So, far we have been maintaining our own expression simplification passes and we continuously need to add more simplification rules. Currently, we have a simplify primitive which is around 700 lines of code and another simplification pass at codegen which is around 100 lines. It might make sense to experiment with using a library for expression simplification instead of writing these on our own. I have tried simplifying some of the important cases we care about in sympy and it does a good job at them (and it can handle other cases that we haven't handled yet).

I think it is worth it to invest a few hours in trying to rewrite all of our simplification using sympy (or some other library) and see if we can pass all of our existing tests.

@SamirDroubi SamirDroubi added C: Internal Implementation detail S: Available Available to be worked upon labels Mar 17, 2024
@SamirDroubi SamirDroubi self-assigned this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Internal Implementation detail S: Available Available to be worked upon
Projects
None yet
Development

No branches or pull requests

1 participant