Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The changes in Quick.Logger.Provider.Memory.pas of change request #103 are producing an exception #107

Open
pjrobin opened this issue Sep 27, 2023 · 3 comments
Open

The changes in Quick.Logger.Provider.Memory.pas of change request #103 are producing an exception #107

pjrobin opened this issue Sep 27, 2023 · 3 comments

Comments

@pjrobin
Copy link
Contributor

pjrobin commented Sep 27, 2023

The changes in Quick.Logger.Provider.Memory.pas of change request #103 are producing an exception: trying to free the critical section in finalization crashes because it's already freed. Reversing the changes works.
@jfudickar
Copy link
Contributor

I've seen this also and can add a fix and add it to the current pull request.

jfudickar added a commit to jfudickar/QuickLogger that referenced this issue Oct 3, 2023
@jfudickar
Fixes excaption when closing the application (exilon#107)
3af7ca6
@jfudickar
Copy link
Contributor

Added a fix to my open pull request.
Now we have to wait.

@exilon
Copy link
Owner

exilon commented Oct 10, 2023

Please see my suggestion changes in PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jfudickar @pjrobin @exilon