New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable Length Quantity could do with a more detailed example table #2027

Open

Gautzilla opened this issue Apr 28, 2022 · 0 comments

Contributor

Gautzilla commented Apr 28, 2022 •

edited

I think the example table with only hexadecimal input and output values can be a little confusing.

On the wikipedia VLQ page, the array details the binary input, the binary output and the hexadecimal output to make the conversion clearer.

Shouldn't the exercise page also specify these steps?
I would suggest adding columns to the table and putting them in the following order:

hexadecimal input | binary input | binary output | hexadecimal output

and emphasize the n°7 bit of each output byte (which is set to 0 in the last byte and set to 1 in the preceding bytes) by making it bold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment