Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Apply common.szs to user page too #34

Open
bandithedoge opened this issue May 25, 2019 · 3 comments
Open

Suggestion: Apply common.szs to user page too #34

bandithedoge opened this issue May 25, 2019 · 3 comments

Comments

@bandithedoge
Copy link

Currently the common.szs option in the injector only applies the diff to common.szs in 0100000000001000 (home menu). The thing is, 0100000000001013 (user page) uses the same file copied to its directory.

@exelix11
Copy link
Owner

Never looked into that file and not sure that's 100% equal, blindly copying files like that could break with fw updates. Guess I could add support for json common patches to user page as well so the json may or may not work without breaking the home menu, even tho idk how useful would that be as the user page isn't really the main focus of themes (and iirc themes still break it)

@bandithedoge
Copy link
Author

It is equal, I've been using the same file for both and it works fine. It can be useful for removing the ugly bottom line.

@Migushthe2nd
Copy link
Contributor

I wanted to add that the common.szs files are not all identical, so indeed blindly copying will break with fw updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants