Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some figs are too large #3

Open
jstac opened this issue Apr 1, 2020 · 7 comments
Open

Some figs are too large #3

jstac opened this issue Apr 1, 2020 · 7 comments

Comments

@jstac
Copy link
Member

jstac commented Apr 1, 2020

These figs are too big: https://executablebookproject.github.io/quantecon-example/docs/about_py.html#graphics

The problem originates on the QE site --- I would love to see this fixed too 馃槵

@choldgraf
Copy link
Member

What do you think is a good "default" behavior for images/figures/etc? This is a bit tricky to get right but we should have reasonable defaults for things

@jstac
Copy link
Member Author

jstac commented Apr 1, 2020

Oh, I think we should just display them as is, leaving adjustment to the user.

This here is a local issue with these particular png files --- they need to be resized themselves or rescaled within the document (if we have the ability to do that now).

@mmcky
Copy link
Member

mmcky commented Apr 1, 2020

we should be able to use :scale: in the directive and sphinx will resize the image.

@jstac
Copy link
Member Author

jstac commented Apr 1, 2020

Thanks @mmcky.

@najuzilu, would you mind to try this for these figures, and any others that seem to be too large?

@najuzilu
Copy link
Member

najuzilu commented Apr 3, 2020

I went over all the figures and they had the same formatting as figures in Python Programming for Quantitative Economics. In any case, I added :scale: 90% or scale: 95% to some of them. Please let me know if they're still too big @jstac.

@jstac
Copy link
Member Author

jstac commented Apr 3, 2020

Thanks @najuzilu

I went over all the figures and they had the same formatting as figures in Python Programming for Quantitative Economics.

Yes, that's why I said "The problem originates on the QE site --- I would love to see this fixed too 馃槵 "

IMO, they are still too big --- for balance, they should be the same size and the charts that proceed them. It would be great if you could make this adjustment.

@najuzilu
Copy link
Member

najuzilu commented Apr 5, 2020

@jstac I tried to keep them roughly the same size. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants