[BUG] The images array is empty. getImages() is not valid!

[BrotherPeng]

🐛 Bug Report

Why can't the code get the image information
Lib version: 4.x.x

I need to get the new information about the image and the location

    const workbook = new ExcelJS.Workbook();
    await workbook.xlsx.load(fs.readFileSync(filePath));
    const worksheet = workbook.getWorksheet(1);
    const images = worksheet.getImages()

The images array is empty.

[snailuncle]

Because your image file name ends with an English period (dot), when you save the file in Excel, it will automatically add another period (dot). So, the image file name saved by Excel becomes two dots. However, when ExcelJS is matching image file names with a regular expression, it looks for '.png', not '..png'. Do you understand?

Please remove the dot before the image file name extension.

  const ext = path.extname(local_img_path).toLowerCase();
  const extensionWithoutDot = ext.startsWith(".") ? ext.substring(1) : ext;

If you want to know why this happens, you can look at the code within ExcelJS

this file : lib/xlsx/xlsx.js

async addMedia(zip, model) {
  await Promise.all(
    model.media.map(async medium => {
      if (medium.type === 'image') {
        const filename = `xl/media/${medium.name}.${medium.extension}`;
        if (medium.filename) {
          const data = await fsReadFileAsync(medium.filename);
          return zip.append(data, {name: filename});
        }
        if (medium.buffer) {
          return zip.append(medium.buffer, {name: filename});
        }
        if (medium.base64) {
          const dataimg64 = medium.base64;
          const content = dataimg64.substring(dataimg64.indexOf(',') + 1);
          return zip.append(content, {name: filename, base64: true});
        }
      }
      throw new Error('Unsupported media');
    })
  );
}

this line of code

const filename = `xl/media/${medium.name}.${medium.extension}`;

During the file save process, your image file name extension has changed from '.png' to '..png'.
i think you get it.

The regular expression code for image matching is in this file.
lib/xlsx/xlsx.js

if (entryName.match(/xl\/media\//) || entryName.match(/xl\/theme\/([a-zA-Z0-9]+)[.]xml/)) {
...
}

[snailuncle]

  const ext = path.extname(local_img_path).toLowerCase();
  const extensionWithoutDot = ext.startsWith(".") ? ext.substring(1) : ext;
  const imageId = workbook.addImage({
    buffer: imageBuffer,
    extension: extensionWithoutDot,
    type: "image",
  });

[snailuncle]

match = entryName.match(/xl/media/([a-zA-Z0-9]+[.][a-zA-Z0-9]{3,4})$/);