Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding images to slides #30

Open
pscanf opened this issue Nov 5, 2021 · 2 comments
Open

Support adding images to slides #30

pscanf opened this issue Nov 5, 2021 · 2 comments
Labels
excalidraw Requires a new Excalidraw feature feature New feature
Milestone

Comments

@pscanf
Copy link
Member

pscanf commented Nov 5, 2021

As discussed in #6, support adding image to slides.

@pscanf pscanf added the feature New feature label Nov 5, 2021
@pscanf pscanf added this to the 2.0.0 milestone Nov 5, 2021
@pscanf pscanf added the excalidraw Requires a new Excalidraw feature label Nov 13, 2021
@hydrosquall
Copy link

👋

I am optimistic that adding support for this will involve upgrading

https://github.com/excalideck/excalideck/blob/master/packages/excalideck-editor/package.json#L24

to

0.11.0

However, since there are breaking API changes in this release, it's possible a few more steps might be needed.

@pscanf
Copy link
Member Author

pscanf commented Mar 4, 2023

Hey @hydrosquall. Sorry for the late reply. Yes, indeed versions after v0.11.0 have that feature. Unfortunately, as you mention, there are breaking changes in the API* which makes it not immediate to upgrade.

I have it in the back of my mind to upgrade, but unfortunately I haven't had the time/need to work on this project for a long time. (Contributions are of course welcome. 🙂 )

  • IIRC, one of the main APIs to get the drawing data becomes async - which means that all Excalideck functions using that API need to become async as well - and the format of the drawing changes slightly to support the inclusion of images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excalidraw Requires a new Excalidraw feature feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants