Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support / fix dark mode #20

Open
pscanf opened this issue Nov 5, 2021 · 2 comments
Open

Support / fix dark mode #20

pscanf opened this issue Nov 5, 2021 · 2 comments
Labels
bug Something isn't working feature New feature polish Improvements polishing the UX
Projects
Milestone

Comments

@pscanf
Copy link
Member

pscanf commented Nov 5, 2021

image

Doubts:

  • should slide miniatures also be rendered in dark mode?
  • should the exported pdf also be rendered in dark mode? (Excalidraw offers an option to export either in light or dark mode, should Excalideck also offer that option?)
@pscanf pscanf added bug Something isn't working feature New feature polish Improvements polishing the UX labels Nov 5, 2021
@pscanf pscanf added this to the 1.0.0 milestone Nov 5, 2021
@pscanf pscanf added this to To do in 1.0.0 Nov 5, 2021
@pscanf
Copy link
Member Author

pscanf commented Nov 9, 2021

Note: the possibility to toggle Dark Mode / change background colour has been removed in #36 (hiding the control with CSS), figuring it's better to have it off than on and broken. It will be re-added when this issue is solved.

@jcezarms
Copy link

Discussing the doubts posed:

  1. It makes contextual sense for all widgets to adhere to dark mode once the canvas has switched. This is standard behavior for dark-mode-enabled interfaces, and is going to be expected by most if not all users.
  2. Similarly as in (1), the users who eventually use both the dark mode and PDF export features will expect a consistent layout between both. I for one have encountered a similar problem in VSCode's Markdown rendering extension in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature polish Improvements polishing the UX
Projects
1.0.0
To do
Development

No branches or pull requests

2 participants