Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reinit lapack_matrix in OperatorBase::internal_compute_factorized_additive_schwarz_matrices() #657

Merged
merged 1 commit into from May 14, 2024
Merged

reinit lapack_matrix in OperatorBase::internal_compute_factorized_additive_schwarz_matrices() #657

merged 1 commit into from May 14, 2024

Conversation

richardschu
Copy link
Contributor

fixes #655
Thanks @bergbauer
did not want to bother you with the request for opening a PR :)

@richardschu richardschu changed the title added reinit() on lapack_matrix reinit lapack_matrix in OperatorBase::internal_compute_factorized_additive_schwarz_matrices() Mar 26, 2024
bergbauer
bergbauer approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@bergbauer bergbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not allocate any new memory but will set all entries to zero. In contrast to factorizing a matrix, these costs should be negligible.

@nfehn nfehn merged commit fcd79b5 into exadg:master May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergbauer bergbauer bergbauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AdditiveSchwarz preconditioner not working in structure module
3 participants
@richardschu @bergbauer @nfehn