Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 objects with ? in key cannot be queried #944

Open
novaugust opened this issue Apr 6, 2023 · 1 comment
Open

S3 objects with ? in key cannot be queried #944

novaugust opened this issue Apr 6, 2023 · 1 comment

Comments

@novaugust
Copy link

  • Do not use the issues tracker for help or support (try Elixir Forum, Slack, IRC, etc.)
  • Questions about how to contribute are fine.

Environment

  • Elixir & Erlang versions (elixir --version): 1.14.2 / otp 25
  • ExAws version: aws 2.4.1 / s3 2.4.0
  • HTTP client version: hackney 1.18.1

Current behavior

could be similar to #546 , where special s3 path parsing breaks reaching an object

s3 objects with ? in the key are unreachable from ex_aws

It's true that S3's key naming strongly recommends against including ? in keys, but it allows and handles them all the same, and they're still accessible via its cli. Alas, in our case the mistake has already been made :)

Expected behavior

s3 objects with ? would ideally be reachable

@bernardd
Copy link
Contributor

Happy to look at a PR for this if there's a sane way to fix it (or even if there's a less-sane way that requires a config option to enable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants