Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken image links on PyPI page for rich-click #99

Open
mhucka opened this issue Dec 7, 2022 · 3 comments
Open

Broken image links on PyPI page for rich-click #99

mhucka opened this issue Dec 7, 2022 · 3 comments

Comments

@mhucka
Copy link

mhucka commented Dec 7, 2022

You are probably aware of this, but just FYI, the images in the PyPI page are all broken, making the screen shots look like this:
image

@ewels
Copy link
Owner

ewels commented Dec 15, 2022

Ah thanks for letting me know 👍🏻

Hmm, this isn't as simple as I'd like to fix unfortunately 🤔 They're generated by rich-codex and as such ideally need relative URLs, which don't work on PyPI. Should be possible by running with a config file instead though I think. I'll look into it..

@canepan
Copy link

canepan commented Jun 5, 2023

Also the links to code examples aren't currently working.
I found an easy fix for those may be to add

 <base href="https://github.com/ewels/rich-click/blob/main/" />

to the pypy index (not sure how to achieve that, though).
Could that help with images, too?

@ewels
Copy link
Owner

ewels commented Oct 12, 2023

Huh, interesting idea! That would be very neat!

We should be able to pass arbitrary HTML within markdown, so hopefully just putting this at the top of README.md should do the job. Then it's a question of whether PyPI will strip out the HTML as a security measure or not..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants