Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have a bigger plan about librosa from python to C/C++. #3

Open
SunAriesCN opened this issue Dec 15, 2020 · 3 comments
Open

Can we have a bigger plan about librosa from python to C/C++. #3

SunAriesCN opened this issue Dec 15, 2020 · 3 comments

Comments

@SunAriesCN
Copy link
Collaborator

Firstly, I think a header import seem not enough to leverage the big library as librosa.
So, cmaking them to dynamic libraries seem like a good idea, and I think we can do something more on audio processing for analysis on C/C++.

@ewan-xu
Copy link
Owner

ewan-xu commented Dec 16, 2020

Thanks for your suggestion!
I agree with your idea about we have a bigger plan about librosa. and I think only import a single header like eigen is a very elegant way for users. we can put librosa API in librosa.h and put it's implemention in other header files.

@xk-wang
Copy link

xk-wang commented Jan 24, 2022

I have added the resample module and the implementation of const Q transform based on your current work. Can I propose PR to your project?

@ewan-xu
Copy link
Owner

ewan-xu commented Jan 25, 2022

wow!nice job. welcome to create a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants