This repository has been archived by the owner on Feb 28, 2020. It is now read-only.
Bring tag behavior in line with builtin messages #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm closing this PR so that I can submit a new one with cleaner commit history and no merge conflicts. |
|
Hi @nthall ! Thanks for your code! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #21 -- adds a level_tag property to the message model, and adds a custom message manager with a method that automatically adds any applicable level_tag to any user-defined tags. Tag behavior now matches builtin messages. I didn't add any new tests for this functionality; I just changed the existing tag-related assertions to match the new expected behavior. I'm happy to add new tests if you think it's necessary.