Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readabiliy improvement panel hides the content of the showcase website #69

Open
Gruximillian opened this issue Apr 11, 2017 · 4 comments

Comments

@Gruximillian
Copy link
Contributor

The readability improvement component buttons hide the content of the complete website. There is no way to undo it other than reloading the page.

https://bovacademy-opensource.github.io/evolution-ui/#site-section-23

@rafael-nunez

@rafael-nunez
Copy link
Contributor

Hi @Gruximillian

I wasn't sure what you were seeing until I tried Firefox. Is that what you're using? I tried yesterday and today to fix this, but fixing it for Firefox is going to take much longer. At different screen widths I see the problem so it is partly related to the media queries of the site, but I also think there are other css rules from other components that are causing problems. For now, it is best to not include it, I think.

@Gruximillian
Copy link
Contributor Author

@rafael-nunez
Yes, I tried in Firefox. Maybe you need to ensure your component is safely namespaced, to write all the rules in a way that they can't be overriden by other components.

@rafael-nunez
Copy link
Contributor

It's a little more complicated. All of my stuff is namespaced. I may have found a fix but it still requires everyone else's rules to be namespaced. Especially whoever is using .hide and .h-hide. until then it is not suitable for Firefox.

@Gruximillian
Copy link
Contributor Author

@rafael-nunez
Oh those helper clasess are not namespaced... damn. I don't use one I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants