Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evm: about gas consume in ethereum side and cosmos side. #1800

Open
4 tasks done
cuiweixie opened this issue Sep 21, 2023 · 8 comments
Open
4 tasks done

evm: about gas consume in ethereum side and cosmos side. #1800

cuiweixie opened this issue Sep 21, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@cuiweixie
Copy link
Contributor

cuiweixie commented Sep 21, 2023

Summary of Bug

consume gas in cosmos and evm module are inconsistent.

Version

latest master

Additional context

consume gas in cosmos side in evm module is in

k.ResetGasMeterAndConsumeGas(ctx, totalGasUsed)

but if evm failed in ApplyMessageWithConfig, this function return err in

return nil, errorsmod.Wrap(err, "failed to apply ethereum core message")

the cosmos side show gasUsed is 0, but evm side is not zero.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Copy link

github-actions bot commented Nov 6, 2023

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.

@MalteHerrmann
Copy link
Contributor

not stale

Copy link

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 30, 2023
@MalteHerrmann
Copy link
Contributor

still not stale 👀

@MalteHerrmann MalteHerrmann reopened this Jan 23, 2024
@hanchon hanchon added the bug Something isn't working label Jan 31, 2024
@0xstepit
Copy link
Contributor

@Vvaradinov @facs95 can be this issue associated with the PR 2302 you opened for the TraceTx?

@facs95
Copy link
Contributor

facs95 commented Feb 14, 2024

@0xstepit No this is a different issue, nothing to do with tracing, this is a difference of gas between cosmos side and evm side during execution. This needs to be address

@VictorTrustyDev
Copy link
Contributor

@Vvaradinov @facs95 can be this issue associated with the PR 2302 you opened for the TraceTx?

No, this is core processor, take effects directly at consensus.

Copy link

github-actions bot commented Apr 1, 2024

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
@MalteHerrmann MalteHerrmann reopened this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants