Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evidently Collector in v0.4.16 #1012

Open
cayla-schuval-klaviyo opened this issue Feb 28, 2024 · 3 comments
Open

Evidently Collector in v0.4.16 #1012

cayla-schuval-klaviyo opened this issue Feb 28, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@cayla-schuval-klaviyo
Copy link

When I try to run evidently collector from version 0.4.16, I am getting the following error:

ImproperlyConfiguredException: 500: Kwarg resolution ambiguity detected for the following keys: i, d. Make sure to use distinct keys for your dependencies, path parameters and
aliased parameters.
@mike0sv
Copy link
Collaborator

mike0sv commented Feb 29, 2024

thanks for reporting! let us take a look at this

@mike0sv mike0sv added the bug Something isn't working label Feb 29, 2024
@c0t0ber
Copy link
Contributor

c0t0ber commented Feb 29, 2024

@mike0sv
I fix it by del query in type Annotation, i can make PR

@mike0sv
Copy link
Collaborator

mike0sv commented Feb 29, 2024

@c0t0ber yes, go ahead. Also you'll need to annotate some routes's return types

c0t0ber added a commit to c0t0ber/evidently that referenced this issue Feb 29, 2024
@c0t0ber
fix: Collector litestar server cant start evidentlyai#1012
54316ac
@c0t0ber c0t0ber mentioned this issue Feb 29, 2024
Merged
@c0t0ber c0t0ber mentioned this issue Mar 15, 2024
Open
emeli-dral pushed a commit that referenced this issue Mar 15, 2024
@c0t0ber @mike0sv @provinzkraut
Feature/add new snapshot trigger and fix collector startup (#1014)
c298435 
* New trigger has been added to initiate a snapshot for the collector based on time or the number of rows

* fix: Collector litestar server cant start #1012

* Implement repeated call of check_snapshots_factory using lifespan

* Update linestar to 2.6.3 litestar-org/litestar#3150

- Schema generation fixed

* Added error logging for snapshot creation

* Added call of synchronous functions using ThreadPoolExecutor in create_snapshot to avoid blocking the loop

* CollectorClient returns the response as a dict

* Added smoke tests for the core functionality of the collector api

* Update tests/collector/test_app.py

Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>

* Skip server tests

---------

Co-authored-by: Mikhail Sveshnikov <mike0sv@gmail.com>
Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mike0sv @c0t0ber @cayla-schuval-klaviyo