Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an embeddable Donation Card #129

Open
osdiab opened this issue Mar 26, 2021 · 2 comments
Open

Make an embeddable Donation Card #129

osdiab opened this issue Mar 26, 2021 · 2 comments
Assignees
Labels

Comments

@osdiab
Copy link
Contributor

osdiab commented Mar 26, 2021

We can use similar structure to the donate button to also create an embeddable donation card, which would take in a donation ID and create the same UI as the donation card on our main website, except using the shadow DOM in other website contexts. We can use the donation API to get all the requisite information:

https://www.every.org/api/donation/1?nonprofitSlug=givewell&username=omar

That already works with a simple GET request. We can also do it with donation IDs:

https://www.every.org/api/donation/7714ab02-66a0-440c-9121-ce8eba9d04b9

@osdiab osdiab added the p1 label Mar 27, 2021
@martinbianchi
Copy link
Contributor

@osdiab which donation card are you referring to?
The idea is to provide another way to the non-profits to show up the donation widget?

@osdiab
Copy link
Contributor Author

osdiab commented Apr 2, 2021

This is separate from the donate button, along with #128 - sorry for the confusion. When someone donates on Every.org we show a card representing their donation on our site; we want those cards to be embeddable on other peoples sites too.

before implementing this I want to nail down if we wanna do it with the shadow dom preact technique here, or via an iframe; there are pros and cons to each. So will self assign until it’s ready

@osdiab osdiab self-assigned this Apr 2, 2021
@osdiab osdiab added p2 and removed p1 labels Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants