Make issue close message optional

[glensc]

Seems weird to require close message, if it is not notified.

@balsdorf what you think to simplify the ui, if close message is not provided, note/email is not created and it is not sent. this means can remove extra ui radio button element.

[cpinfold]

I agree the note shouldn't be required. However we do note some issues on closure even when we don't want notification sent. That use case wouldn't allow removing the Yes/No. You could change the notification send to radio list to include a "Do not notify" option. And then remove the yes/no. That would make more sense because if you select no, who you are notifying is ignored. Craig

…

On Tue, Mar 12, 2019, 4:27 AM Elan Ruusamäe ***@***.***> wrote: Seems weird to require close message, if it is not notified. [image: image] <https://user-images.githubusercontent.com/199095/54185103-e3e6d700-44b0-11e9-9183-ea0a7339cb23.png> @balsdorf <https://github.com/balsdorf> what you think to simplify the ui, if close message is not provided, note/email is not created and it is not sent. this means can remove extra ui radio button element. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#503>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKnrsQIQkriWHjYaQYTRMeM5pIsHg6pbks5vV2UDgaJpZM4bqUMy> .

[balsdorf]

I like what Craig said.

…

On Tue, Mar 12, 2019, 7:32 AM Craig ***@***.***> wrote: I agree the note shouldn't be required. However we do note some issues on closure even when we don't want notification sent. That use case wouldn't allow removing the Yes/No. You could change the notification send to radio list to include a "Do not notify" option. And then remove the yes/no. That would make more sense because if you select no, who you are notifying is ignored. Craig On Tue, Mar 12, 2019, 4:27 AM Elan Ruusamäe ***@***.***> wrote: > Seems weird to require close message, if it is not notified. > > [image: image] > < https://user-images.githubusercontent.com/199095/54185103-e3e6d700-44b0-11e9-9183-ea0a7339cb23.png > > > @balsdorf <https://github.com/balsdorf> what you think to simplify the > ui, if close message is not provided, note/email is not created and it is > not sent. this means can remove extra ui radio button element. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#503>, or mute the thread > < https://github.com/notifications/unsubscribe-auth/AKnrsQIQkriWHjYaQYTRMeM5pIsHg6pbks5vV2UDgaJpZM4bqUMy > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#503 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHzdQNrIlbV904BAcT9kzkiCvBY7eX2ks5vV55mgaJpZM4bqUMy> .