Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default access_level for all issues #483

Open
areis422 opened this issue Feb 27, 2019 · 6 comments
Open

Change default access_level for all issues #483

areis422 opened this issue Feb 27, 2019 · 6 comments

Comments

@areis422
Copy link

Hi everyone,

Upon upgrading from 2.3.0 (I know, old as hell), I see the private bit has been removed in favor of Access Level. I don't see anywhere to either edit the names or change the default access level for any newly created issues. Am I missing something or is #141 only a partial implementation? Also, if there is a way to set a default, where does $defaults come from for smarty to use? I'm assuming setup.php, but didn't see any documentation as to all available configuration options that could be put in either Config.php or setup.php.

Thanks,
Drew

@glensc glensc added this to the 3.6.1 milestone Feb 27, 2019
@glensc
Copy link
Member

glensc commented Feb 27, 2019

Please, each problem separate issue. It will get difficult to handle different problems in same issue.

for #141, added screenshot to #141
as i see, you can now choose two types, and specific users who can access

don't know what you mean by $default, missing context. please point to code line

@areis422
Copy link
Author

Hey @glensc

I understand the use for the access level. Problem is, in 2.3.0, we were able to set a default for the private flag.

In our use case, we'd want ALL issues to be private, unless determined they needed to be public. We use a SQL Server linked server to query the eventum database for SSRS reports.

Essentially, on a per project basis, "Default Access Level" -> Dropdown containing access levels
That selection would automatically set any new issues created to that access level.

Does that make sense?

@glensc
Copy link
Member

glensc commented Feb 28, 2019

please share your changes how you made it default in 2.3 (links to code, etc), might help getting this done for current version sooner. or can even submit PR against 2.3 branch: https://github.com/eventum/eventum/tree/eventum-2.3

@glensc glensc modified the milestones: 3.6.1, 3.6.2 Feb 28, 2019
@areis422
Copy link
Author

areis422 commented Mar 4, 2019

The changes I made were in:
lib/eventum/class.access.php - public static function getAccessLevels() - Line 524
templates/view_form.tpl.html - Line 35
templates/list.tpl.html - Line 154

I believe the access levels shouldn't be this hardcoded array in the class, but rather a lookup table in the database to which referential integrity can be added.

Also, in the html templates, smarty is doing a comparison to "normal" for any messages. These should also be DB driven

@glensc glensc modified the milestones: 3.6.2, 3.6.3 Mar 8, 2019
@glensc glensc modified the milestones: 3.6.3, 3.6.4 Mar 21, 2019
@glensc glensc modified the milestones: 3.6.4, 3.6.5 Mar 28, 2019
@glensc glensc modified the milestones: 3.6.5, 3.6.6 Apr 10, 2019
@glensc glensc modified the milestones: 3.6.6, 3.6.7 Apr 20, 2019
@glensc glensc modified the milestones: 3.6.7, 3.7.0 Apr 29, 2019
@glensc
Copy link
Member

glensc commented May 1, 2019

i can't find lib/eventum/class.access.php in 2.3.6 release:

@areis422
Copy link
Author

areis422 commented May 1, 2019 via email

@glensc glensc removed this from the 3.7.0 milestone May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants