Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage in Display area #791

Open
JakubVanek opened this issue Jan 9, 2021 · 3 comments
Open

Increase test coverage in Display area #791

JakubVanek opened this issue Jan 9, 2021 · 3 comments

Comments

@JakubVanek
Copy link
Contributor

Current unit testing solution for the display stack is inadequate. A revision of the current testing code is necessary.

@jabrena jabrena added this to the v1.1.0 milestone Jan 9, 2021
@jabrena
Copy link
Member

jabrena commented Jan 9, 2021

Yep, it is something missing in the library. When we added the nice EV3 Display support, we forget adding it.

Currently, we have this status:

image

  • ev3dev.actuators
  • ev3dev.hardware.display
  • ev3dev.utils.io
  • ev3dev.hardware.display.spi

image

  • LCDStretch
  • LCD
  • LCDStretch.Flusher

image

image

image

With that contribution, we could enable again the following configuration to reach 80% of code coverage:

jacocoTestCoverageVerification {
    violationRules {
        rule {
            limit {
                //minimum = 0.75 // implement more tests
                minimum = 0.2
            }
        }
    }
}

Related issue: #726

@jabrena jabrena modified the milestones: v1.1.0, v1.0.0 Jan 9, 2021
@jabrena jabrena changed the title Display architecture - increase test coverage Increase test coverage in Display area Jan 9, 2021
@JakubVanek
Copy link
Contributor Author

Given that LCDJessie is implemented as a separate class, it seems that the BitFramebuffer & FramebufferProvider paths are mostly redundant. Removing them might reduce the amount of code that needs testing.

@jabrena
Copy link
Member

jabrena commented Jan 9, 2021

Create a PR with this small change. I will merge directly to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants