Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release commit log link broken #261

Open
clabe45 opened this issue Feb 19, 2024 · 0 comments
Open

Release commit log link broken #261

clabe45 opened this issue Feb 19, 2024 · 0 comments

Comments

@clabe45
Copy link
Collaborator

clabe45 commented Feb 19, 2024

Etro uses ShipJS to deploy new versions. Along with publishing versions to NPM and doing some other release chores, by default, Ship.js creates GitHub releases, extracting the release notes from CHANGELOG.md. Since the header link's destination is declared at the bottom of CHANGELOG.md, a ShipJS bug prevents the link's destination from being included in the GitHub release notes, so the link does not render properly (example). I tried to fix this in ccd6c55, but the issue is still happening. I believe it's because releases needs to be an object, not an array (ShipJS docs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant