Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate mediaRecorderOptions #251

Open
clabe45 opened this issue Feb 14, 2024 · 0 comments
Open

Deprecate mediaRecorderOptions #251

clabe45 opened this issue Feb 14, 2024 · 0 comments
Labels
good first issue Good for newcomers priority:low type:refactor

Comments

@clabe45
Copy link
Collaborator

clabe45 commented Feb 14, 2024

Movie.record() uses a MediaRecorder to capture and encode the output video. The method accepts a mediaRecorderOptions object, which are forwarded to the MediaRecorder constructor. This introduces leaky abstraction; this object should be deprecated. We can later replace this object with individual Movie.record() options if we need to, but for now let's just deprecate mediaRecorderOptions.
jeevikasirwani added a commit to jeevikasirwani/etro that referenced this issue Mar 17, 2024
@jeevikasirwani
Deprecate mediaRecorderOptions etro-js#251
4fb7c63 
added a line
@deprecated Use individual options instead of mediaRecorderOptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers priority:low type:refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clabe45