Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate the random wallet #358

Open
Hirama opened this issue Aug 29, 2023 · 3 comments
Open

Generate the random wallet #358

Hirama opened this issue Aug 29, 2023 · 3 comments
Labels

Comments

@Hirama
Copy link

Hirama commented Aug 29, 2023

Generate a new random wallet on initial start-up, as providing a pre-drained wallet can lead to user confusion.
image

@naps62
Copy link
Member

naps62 commented Aug 29, 2023

Thanks for starting this discussion.

I think the intended direction is something different though, keeping in line with the fact this is meant for developers
What I'm imagining is the onboarding flow (which currently only asks for Alchemy API key) including the ability to opt-in to having the test test ... junk wallet, while also making it clear it is only for test purposes.

Switching to a randomly-generated wallet is counterproductive, as it is the wallet that is funded by default when booting anvil / hardhat.

@Hirama
Copy link
Author

Hirama commented Aug 30, 2023

Indeed, you're correct. However, by monitoring on-chain activity, it becomes clear that this "method" is counterproductive and needs terminating, as a multitude of users are losing their test tokens. Incidentally, Hardhat does not display user wallets directly as your application does. So if it possible to add some hints that address is compromised or something else?

@naps62
Copy link
Member

naps62 commented Aug 31, 2023

yes, adding some hints on the UI can definitely be done (and makes sense)

@naps62 naps62 added the feature label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants